Skip to content

feat: allow passing command line arguments running an app in the iOS Simulator #5518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 1, 2021

Conversation

pfumagalli
Copy link
Contributor

@pfumagalli pfumagalli commented Apr 13, 2021

The IOS_SIMULATOR_RUN_ARGS environment variable allows specific command line arguments to be passed to the simulator when running an app.

This is extremely useful when working (for example) with Firebase and having to debug events or other internals:

https://firebase.google.com/docs/analytics/debugview

The command line arguments -FIRDebugEnabled and -FIRDebugDisabled control the behaviour of Firebase in combination with its realtime event debugging console.

With this patch, enabling debugging is as easy as calling:

IOS_SIMULATOR_RUN_ARGS=-FIRDebugEnabled ns run ios

…imulator

The `IOS_SIMULATOR_RUN_ARGS` environment variable allows specific command line arguments
to be passed to the simulator when running an app.

This is _extremely_ useful when working (for example) with Firebase and having to debug
events or other internals:

https://firebase.google.com/docs/analytics/debugview

The command line arguments `-FIRDebugEnabled` and `-FIRDebugDisabled` control the behavior
of Firebase in combination with its realtime event debugging console.

With this patch, enabling debugging is as easy as calling:

```bash
IOS_SIMULATOR_RUN_ARGS=-FIRDebugEnabled ns run ios
```
@cla-bot
Copy link

cla-bot bot commented Apr 13, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @pfumagalli.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@pfumagalli
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Apr 13, 2021
@cla-bot
Copy link

cla-bot bot commented Apr 13, 2021

The cla-bot has been summoned, and re-checked this pull request!

@pfumagalli pfumagalli changed the title Allow passing command line arguments running an app in the iOS Simulator feat: allow passing command line arguments running an app in the iOS Simulator Apr 13, 2021
@NathanWalker NathanWalker requested a review from rigor789 April 13, 2021 22:58
@cla-bot
Copy link

cla-bot bot commented Jun 1, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @pfumagalli.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@cla-bot cla-bot bot removed the cla: yes label Jun 1, 2021
@rigor789
Copy link
Member

rigor789 commented Jun 1, 2021

Hey @pfumagalli thanks for the PR, lgtm - we recently had to change our CLA and need you to fill it out again, sorry for the inconvenience - but since this was submitted with the old CLA, I'll go ahead and merge it.

@rigor789 rigor789 merged commit 6b700b4 into NativeScript:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants